On 11/12/2016 01:01 AM, Barry wrote:
Barry
> On 10 Nov 2016, at 15:21, Chenxiong Qi <cqi(a)redhat.com> wrote:
>
>
>
>> On 11/10/2016 09:42 PM, Barry Scott wrote:
>> In this bug
>>
>>
https://bugzilla.redhat.com/show_bug.cgi?id=1360797
>>
>> It is implied that rpkg has an unspecified problem with GitPython 2.0.
>>
>> This is preventing the maintainer from updating to the any GitPython 2
>> release.
>>
>> I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.
>>
>
> Import error here.
>
> File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in <module>
> import git
> File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line
38, in <module>
> from git.config import GitConfigParser # @NoMove @IgnorePep8
> File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25,
in <module>
> from git.util import LockFile
> File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in
<module>
> from unittest.case import SkipTest
> ImportError: No module named case
>
> GitPython >= 2 cannot work with Python 2.6 at all.
So on a system where you want to use rpkg with python 2.6 use GitPython 1.
But that is no reason to stop updating GitPython 2 for Fedora 24 where python 2.7
Is used for rpkg right?
I've tested GitPython >= 2 with rpkg by running all existent tests, that
covers most of the calls to GitPython API. All tests passed, and I don't
see an issue. I'm glad to see the upgrade too. I think the upgrade
should not be a big issue to rpkg, as there is still GitPython 1.x in EPEL6.
Barry
>
>> If there is a problem it would be nice if the rpkg people could comment on the
>> difficult of supporting GitPython 2. The python2.6 support question I suspect
>> can be handled by version checking in any conflicting code.
>>
>> It seems wrong that rpkg is blocking updating to the latest GitPython,
>> preventing user of GitPython getting the bugs fixes and (as far as I am aware)
>> backwards compatible improvements.
>>
>> Barry
>> _______________________________________________
>> devel mailing list -- devel(a)lists.fedoraproject.org
>> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>>
>
> --
> Regards,
> Chenxiong Qi
> _______________________________________________
> devel mailing list -- devel(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
--
Regards,
Chenxiong Qi