[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=820729
--- Comment #2 from Marc-Andre Lureau <marcandre.lureau(a)redhat.com> ---
(In reply to comment #1)
> Taking for review
>
> - The BuildRoot tag, the entire %clean section and the %defattr tags in the
> %files sections aren't needed any more with modern RPM and can be removed
> - Please remove the use of the %{summary} macro and give the -static
> subpackages a more proper summary
thanks, done
> The unpack procedure in the %prep section is a bit odd, but I guess this is
> caused by the fact that current RPM doesn't support 7zip archives yet.
Yes, I know cfergeau(a)redhat.com has been working on a rpm patch.
> The %mingw_debug_install_post call in the %install section shouldn't be
> necessary. As it already contains a FIXME comment I'll try to investigate
> this issue here
As I say in the spec, I have no idea why we need to call it ourself, I would be
glad to get some help, as I don't know how to debug this one.
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 11 months
[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=820729
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fedora(a)vanpienbroek.nl
Assignee|nobody(a)fedoraproject.org |erik-fedora(a)vanpienbroek.nl
--- Comment #1 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
Taking for review
- The BuildRoot tag, the entire %clean section and the %defattr tags in the
%files sections aren't needed any more with modern RPM and can be removed
- Please remove the use of the %{summary} macro and give the -static
subpackages a more proper summary
The unpack procedure in the %prep section is a bit odd, but I guess this is
caused by the fact that current RPM doesn't support 7zip archives yet.
The %mingw_debug_install_post call in the %install section shouldn't be
necessary. As it already contains a FIXME comment I'll try to investigate this
issue here
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 11 months
[Bug 823623] Review Request: mingw-libusb1 - MinGW library which allows userspace access to USB devices
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=823623
Hans de Goede <hdegoede(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |hdegoede(a)redhat.com
Flags| |fedora-review?
--- Comment #1 from Hans de Goede <hdegoede(a)redhat.com> ---
Hi,
I'll review this, but first can you please re-spin the package to be based on
libusbx? libusbx is a fork of libusb by most of the libusb developers for
various reasons. The developers behind the fork include yours truly, as well as
the windows maintainer, making libusbx a better starting point for a mingw
package.
Notice that the regular Fedora libusb package is also moving over to libusbx,
see bug 823886 for the Rename Review Request for that, including the new
specfile for a libusbx based Fedora libusb package.
Regards,
Hans
--
You are receiving this mail because:
You are on the CC list for the bug.
11 years, 11 months
[Bug 822312] -fstack-protector-all results in dynamic dependency on libssp-0.dll
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=822312
--- Comment #6 from Gregory Maxwell <gmaxwell(a)gmail.com> 2012-05-18 12:40:43 EDT ---
If you say so— though this simply isn't the behavior it has on native binaries:
[gmaxwell@helmholtz tmp]$ gcc test.c -o test -fstack-protector-all
[gmaxwell@helmholtz tmp]$ ldd test
linux-vdso.so.1 => (0x00007fffc618e000)
libc.so.6 => /lib64/libc.so.6 (0x00000038ef600000)
/lib64/ld-linux-x86-64.so.2 (0x00000038ef200000)
Though yes indeed, it confuses the heck out of libtool which actually was my
problem in getting it to produce a static binary— intermediate libraries were
introducing the dynamic dependency when -static was only set at the final
linking stage.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11 years, 11 months