On July 31, 2014, 2:44 p.m., Miloslav Trmac wrote:
> src/rolekit/server/dbusrole.py, lines 206-207
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/1/?file=238#file238...
>
> What does “private” mean in this context BTW? It's obviously neither
class-private nor file-private.
Private means here that is it not visible via D-Bus.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/55/#review191
-----------------------------------------------------------
On July 30, 2014, 3:33 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/55/
-----------------------------------------------------------
(Updated July 30, 2014, 3:33 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Fixes
https://fedorahosted.org/rolekit/ticket/3
Diffs
-----
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15
src/rolekit/server/roled.py 59d1523347325b20d666c99d8c2087c8ce486608
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/55/diff/
Testing
-------
Thanks,
Thomas Woerner