On Srp. 19, 2014, 4:56 odp., Miloslav Trmac wrote:
> config/roles/testrole/role.py, lines 105-106
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/66/diff/1/?file=259#file259...
>
> Documentation IMHO belongs into RoleBase, not to be copy&pasted in all
roles. If necessary, attach it to to a method that only raises NotImplemeted (or returns
False?)
>
> Also, please keep the interfaces of all roles in sync (i.e. when adding a method
to one, add it to all.)
And finally, having this a docstring instead of a comment would be nice. Tools understand
docstrings.
- Miloslav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/66/#review230
-----------------------------------------------------------
On Srp. 18, 2014, 2:03 odp., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/66/
-----------------------------------------------------------
(Updated Srp. 18, 2014, 2:03 odp.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
This is needed to be able to check types of role specific properties.
Diffs
-----
config/roles/testrole/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9
src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/66/diff/
Testing
-------
Thanks,
Thomas Woerner