On Aug. 1, 2014, 11:34 a.m., Simo Sorce wrote:
> config/roles/testrole/role.py, lines 139-145
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/17/diff/1/?file=91#file91li...
>
> is this improperly indented ?
> sounds like it should be in do_get_dbus_property() but it isn't this way
It is not in do_get_dbus_property. If property is available in dbus.service, then we are
using the new property model (latest Fedora additions to dbus-python), then this method is
needed. Otherwise the old model is needed and done automatically in the Get method in
RoleBase.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/17/#review199
-----------------------------------------------------------
On July 22, 2014, 3:35 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/17/
-----------------------------------------------------------
(Updated July 22, 2014, 3:35 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Simplifies the role interface
Role cleanup by dropping "failonthis" setting
Diffs
-----
config/roles/testrole/role.py 2f077c62b4a8027e7783a2e08c84bc9c9715393e
src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/17/diff/
Testing
-------
Thanks,
Thomas Woerner