----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/72/#review260 ----------------------------------------------------------- Ship it! Ship It! src/rolekit/async.py <http://reviewboard-fedoraserver.rhcloud.com/r/72/#comment158> Just curious—is there a reason to use {} and .format instead of %s and ""%(..) ? - Miloslav Trmac On Srp. 20, 2014, 10:57 odp., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/72/ ----------------------------------------------------------- (Updated Aug. 21, 2014, 11:53 a.m.) Status ------ This change has been marked as submitted. Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- There are several places where we simply log an exception without any context. This patch adds the exception type to these messages to improve debugging. Diffs ----- src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f src/rolekit/server/decorators.py ae30cd8ad7d16b02accdc95bd0dd0f22cbc581ae src/rolekit/server/rolebase.py cd28d6a47cf183f6017905034f178d7aecf83348 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/72/diff/ Testing ------- Thanks, Stephen Gallagher