----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/ ----------------------------------------------------------- (Updated Čec. 30, 2014, 12:31 dop.) Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Implement starting and stopping services, and use it in databaseserver. Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked. Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary. Diffs (updated) ----- TODO 053560af7e811ae9d26b7eafff92ac2786af5408 config/roles/databaseserver/role.py b632321de63c331b3b3d0445d134fe1626e9944c src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/ Testing ------- starting/stopping postgres through d-feet. Thanks, Miloslav Trmac

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/ ----------------------------------------------------------- (Updated Čec. 30, 2014, 3:38 odp.) Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Implement starting and stopping services, and use it in databaseserver. Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked. Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary. Diffs (updated) ----- TODO 053560af7e811ae9d26b7eafff92ac2786af5408 config/roles/databaseserver/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/ Testing ------- starting/stopping postgres through d-feet. Thanks, Miloslav Trmac

There are actually three moving parts (the logging, the manager call, and the error message), adding a boolean (or more parameters) would be adding ~7 lines to save 8 lines. Can we wait with this for restartServices? Then we will see what precisely are the common and unique parts, and see what the cleanest way to abstract things is. I don’t have a good intuition for this at the moment. (This might involve s/SystemdJobHandler/SystemdServiceHandler/ and passing it the services, thus encapsulating the for loop, and a SystemdJobsResult object encapsulating the last three lines. But I’d rather see the last user first.) - Miloslav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/#review225 ----------------------------------------------------------- On Čec. 30, 2014, 3:38 odp., Miloslav Trmac wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/ ----------------------------------------------------------- (Updated Srp. 19, 2014, 9:27 odp.) Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Implement starting and stopping services, and use it in databaseserver. Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked. Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary. Diffs (updated) ----- TODO 90fcb3f668aa382f0317092a25d794d37e012b23 config/roles/databaseserver/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py a54a3b61b107775140a944a94bedd2dd0fa4ec81 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/ Testing ------- starting/stopping postgres through d-feet. Thanks, Miloslav Trmac

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/ ----------------------------------------------------------- (Updated Srp. 19, 2014, 9:41 odp.) Status ------ This change has been marked as submitted. Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Implement starting and stopping services, and use it in databaseserver. Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked. Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary. Diffs ----- TODO 90fcb3f668aa382f0317092a25d794d37e012b23 config/roles/databaseserver/role.py 358deca3fc7172929d53d2c77efd5c919da2aea9 src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py a54a3b61b107775140a944a94bedd2dd0fa4ec81 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/ Testing ------- starting/stopping postgres through d-feet. Thanks, Miloslav Trmac