On Aug. 20, 2014, 11:18 a.m., Miloslav Trmac wrote:
> src/rolekit/async.py, line 230
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/1/?file=281#file281...
>
> “debug level 9” depends on a parameter and is actually not true in any existing
invocation.
>
> (Should log_fn even have a default value? I can see the case for having it, but
then we are not using it at this moment.)
Whoops, I originally had level 9 hard-coded, then added the parameter and forgot to change
the comment.
Yeah, I'll remove the default.
On Aug. 20, 2014, 11:18 a.m., Miloslav Trmac wrote:
> src/rolekit/async.py, lines 232-234
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/1/?file=281#file281...
>
> for line in lines[:-1]: log_fn(line)
Miloslav Trmac wrote:
… and then use lines[-1] below.
Thanks, my C background was showing.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/71/#review237
-----------------------------------------------------------
On Aug. 20, 2014, 2:05 a.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/71/
-----------------------------------------------------------
(Updated Aug. 20, 2014, 2:05 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
In the original approach, it was impossible to monitor the
progress of a subprocess because all of the stdout/stderr was
being buffered for retrieval only after the process exited.
With this patch, we will now drop stdout into log.debug1() and
stderr into log.error() as they come in (in addition to storing
the complete results for retrieval later). This will make
debugging efforts much simpler.
Diffs
-----
src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/
Testing
-------
Testing was performed alongside the Domain Controller deployment. With this patch, I was
able to see how far along the deployment had gotten.
Thanks,
Stephen Gallagher