From: Joseph Marrero jmarrero@gmail.com Date: Wed, Mar 6, 2013 at 11:40 PM Subject: Re: [mirall] plasma client try3 To: Kevin Fenzi kevin@scrye.com
I am preparing the package for upstream merge between mirall and owncloud-plasma-client This is are test builds, they are not going to be pushed to any kind of updates until the official builds have been merged together the issue with the lib is resolved in the current upstream but in the owncloud-plasma-client is not.
Let me know if I should not make it build to test in the f19 repos.
On Wed, Mar 6, 2013 at 11:33 PM, Kevin Fenzi kevin@scrye.com wrote:
On Wed, 6 Mar 2013 01:00:26 +0000 (UTC) Joseph Marrero jmarrero@fedoraproject.org wrote:
commit 868b82191f2627c6f34d64abb554b06e53de41fb Author: Joseph Marrero jmarrero@fedoraproject.org Date: Tue Mar 5 20:59:46 2013 -0400
plasma client try3
mirall.spec | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mirall.spec b/mirall.spec index 3ef7fd5..9a0bb17 100644 --- a/mirall.spec +++ b/mirall.spec @@ -97,7 +97,8 @@ fi #remove libmirallsync on official merge %{_libdir}/libmirallsync.so %{_libdir}/libowncloudsync.so
+##for some reason this is unlinked in this mirall pull, in the uptream version is working +/usr/lib/libowncloudsync.so # re activate when officially merged#%{_libdir}/libowncloudsync.so.0 #%{_libdir}/libowncloudsync.so.%{version}
What are you trying to do here?
The x86_64 version of this package shouldn't ship any libraries in /usr/lib/
Is this some issue with upstreams make install? Why not manually install it in the right place?
kevin
Joseph Marrero wrote:
From: Joseph Marrero jmarrero@gmail.com Date: Wed, Mar 6, 2013 at 11:40 PM Subject: Re: [mirall] plasma client try3 To: Kevin Fenzi kevin@scrye.com
I am preparing the package for upstream merge between mirall and owncloud-plasma-client
Looks like the root cause is more likely this snippet from src/CMakeLists.txt:
install(TARGETS owncloudsync RUNTIME DESTINATION bin LIBRARY DESTINATION lib ARCHIVE DESTINATION lib BUNDLE DESTINATION library )
contrast this with similar (and imo better) snippet about mirall:
install(TARGETS mirall RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} )
See how the former hard-codes relative paths bin and lib? (not good, from a packaging-perspective anyway)
-- rex