On Friday, February 9, 2018 9:25:33 AM CET Igor Gnatenko wrote:
On Fri, 2018-02-09 at 08:57 +0100, Pavel Raiskup wrote:
> On Thursday, February 8, 2018 5:02:10 PM CET Igor Gnatenko wrote:
> > Hello everyone,
> >
> > It seems that a lot of people have %file, %check, %build, %whatsoever in
> > their
> > changelog section.
> >
> > Is there any reason I should not go and automatically escape them?
>
> There's IMO no good reason why you should.
>
> I wouldn't use proven packager rights if the package builds fine. Fill a
> pull request if anything.
Then I have doubts that %changelog means anything
It means something but it is not that important to not ship such package.
because whoever uses rpm -- changelog would see unexpanded macro so
if
you had %autosetup -p1 in there, users would see real commands
instead... And also it might break in some cases which requires
maintainer intervention.
I only said why I wouldn't use _my_ provenpackager powers for innocent
issues.
Also I don't see reason why I should send PR for ~500 packages
where most of it
won't be merged ever. And this will create much more problems for me to track
this issue rather than just going and fixing all of them.
Though it only delayed (lowered priority of) the real solution ...
> E.g. server-side git hook refusing commits "adding
typos" into changelog
> would solve it once and forever. If you were able to implement some
> systematic change like this then I would excuse the walk across all the
> spec files to fix old issues..
https://pagure.io/releng/issue/7300
.. like this. Thanks!
Pavel