On Thu, 20 Jan 2022 at 12:54, Kaleb Keithley <kkeithle(a)redhat.com> wrote:
>
>
> I thought I'd solved all my gcc-12-isms in ceph by running --scratch
--arch-override=x86_64 builds, so I tried a full build and ran into this on aarch64. :-(
>
> /usr/bin/g++ -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION
-DBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64
-D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D__CEPH__
-D__STDC_FORMAT_MACROS -D__linux__
-I/builddir/build/BUILD/ceph-16.2.7/build/redhat-linux-build/src/include
-I/builddir/build/BUILD/ceph-16.2.7/src -isystem
/builddir/build/BUILD/ceph-16.2.7/build/redhat-linux-build/include -isystem
/builddir/build/BUILD/ceph-16.2.7/src/xxHash -isystem
/builddir/build/BUILD/ceph-16.2.7/src/rapidjson/include -isystem /usr/include/python3.10
-O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard
-fasynchronous-unwind-tables -fstack-clash-protection -O2 -g -DNDEBUG -fPIE
-U_FORTIFY_SOURCE -Wall -fno-strict-aliasing -fsigned-char -Wtype-limits
-Wignored-qualifiers -Wpointer-arith -Werror=format-security -Winit-self
-Wno-unknown-pragmas -Wnon-virtual-dtor -Wno-ignored-qualifiers -ftemplate-depth-1024
-Wpessimizing-move -Wredundant-move -Wstrict-null-sentinel -Woverloaded-virtual
-fno-new-ttp-matching -fstack-protector-strong -fdiagnostics-color=auto
-fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -std=c++17
-MD -MT src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o -MF
src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o.d -o
src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o -c
/builddir/build/BUILD/ceph-16.2.7/src/mgr/ActivePyModule.cc
> FAILED: src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o
> /usr/bin/g++ -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION
-DBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64
-D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D__CEPH__
-D__STDC_FORMAT_MACROS -D__linux__
-I/builddir/build/BUILD/ceph-16.2.7/build/redhat-linux-build/src/include
-I/builddir/build/BUILD/ceph-16.2.7/src -isystem
/builddir/build/BUILD/ceph-16.2.7/build/redhat-linux-build/include -isystem
/builddir/build/BUILD/ceph-16.2.7/src/xxHash -isystem
/builddir/build/BUILD/ceph-16.2.7/src/rapidjson/include -isystem /usr/include/python3.10
-O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard
-fasynchronous-unwind-tables -fstack-clash-protection -O2 -g -DNDEBUG -fPIE
-U_FORTIFY_SOURCE -Wall -fno-strict-aliasing -fsigned-char -Wtype-limits
-Wignored-qualifiers -Wpointer-arith -Werror=format-security -Winit-self
-Wno-unknown-pragmas -Wnon-virtual-dtor -Wno-ignored-qualifiers -ftemplate-depth-1024
-Wpessimizing-move -Wredundant-move -Wstrict-null-sentinel -Woverloaded-virtual
-fno-new-ttp-matching -fstack-protector-strong -fdiagnostics-color=auto
-fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -std=c++17
-MD -MT src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o -MF
src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o.d -o
src/mgr/CMakeFiles/ceph-mgr.dir/ActivePyModule.cc.o -c
/builddir/build/BUILD/ceph-16.2.7/src/mgr/ActivePyModule.cc
> In file included from /usr/include/boost/integer.hpp:20,
> from /usr/include/boost/integer/integer_mask.hpp:16,
> from /usr/include/boost/random/mersenne_twister.hpp:26,
> from /usr/include/boost/uuid/random_generator.hpp:17,
> from /usr/include/boost/uuid/uuid_generators.hpp:17,
> from /builddir/build/BUILD/ceph-16.2.7/src/include/uuid.h:16,
> from /builddir/build/BUILD/ceph-16.2.7/src/include/types.h:21,
> from /builddir/build/BUILD/ceph-16.2.7/src/msg/msg_types.h:23,
> from
/builddir/build/BUILD/ceph-16.2.7/src/common/ceph_context.h:36,
> from /builddir/build/BUILD/ceph-16.2.7/src/common/dout.h:29,
> from /builddir/build/BUILD/ceph-16.2.7/src/common/debug.h:18,
> from
/builddir/build/BUILD/ceph-16.2.7/src/mgr/ActivePyModule.cc:16:
> /usr/include/boost/integer_traits.hpp:83:64: error: narrowing conversion of
'255' from 'int' to 'char' [-Wnarrowing]
> 83 | public detail::integer_traits_base<char, CHAR_MIN, CHAR_MAX>
> |
>
>
https://koji.fedoraproject.org/koji/taskinfo?taskID=81520773
>
> Are we expecting an update to boost by any chance?
No, not for F36 (it would be a systemwide change, and we prefer to do
it before the mass rebuild if we do it).
I don't think this is a problem with Boost anyway. This error makes no
sense. Either char is signed, in which case CHAR_MAX should be 127, or
char is unsigned in which case char{255} is not narrowing.
The command line shows -fsigned-char so CHAR_MAX should be 127.
Something is badly wrong somewhere.