On Thu, 19 Jan 2023 at 10:52, Michal Schorm <mschorm(a)redhat.com> wrote:
Hello,
While playing around with Sourcegraph, which indexed all Fedora
package repositories, I was able to craft a query listing all '%if'
conditionals referencing Fedora releases that reached EOL.
https://sourcegraph.com/search?q=context:global+repo:%5Esrc%5C.fedoraproj...
I don't believe such conditions have any value and I think we can
remove them right away.
I think the removal shouldn't affect neither Fedora nor derived
operating systems.
If removed, they will be preserved in the git history anyway, for
anyone seeking historical code.
In some cases the conditionals hold patches that could be removed with them:
https://sourcegraph.com/search?q=context:global+repo:%5Esrc%5C.fedoraproj...
--
Do you agree it would be safe to remove such conditionals and the code
they hold ?
For the packages I (co)maintain, I see no value in keeping it. Maybe
somebody has a reason for keeping it in their specs, but I can't see
any value in it.
Do you agree that removing obsolete code such as this brings value
to
the package codebase ?
Yes, it makes it easier for others to open the spec file and quickly
understand what it's doing.
Would you see a value in e.g. some kind of a robot reminding
maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
check)
I don't think that's worth the effort/noise.