6:01 a.m.
I just had to fix a number of my servers that use node exporter.
The service name has been changed. Why was this done and did no one
think about the impact on users?
In the worst case I had a server fail to reboot because I had
Requires=node_exporter.service in the default target.
Barry
6:10 a.m.
New subject: Why was node_exporter.service renamed to prometheus-node-exporter.service?
On Friday, 28 January 2022 12:01:43 GMT Barry Scott wrote:
I just had to fix a number of my servers that use node exporter.
The service name has been changed. Why was this done and did no one
think about the impact on users?
In the worst case I had a server fail to reboot because I had
Requires=node_exporter.service in the default target.
Was:
$ rpm -ql golang-github-prometheus-node-exporter-1.2.2-1.fc35.x86_64 | grep
service
/etc/systemd/system/node_exporter.service
/usr/share/doc/golang-github-prometheus-node-exporter/examples/systemd/
node_exporter.service
Now is:
$ rpm -ql golang-github-prometheus-node-exporter-1.3.1-4.fc35.x86_64 | grep
service
/usr/lib/systemd/system/prometheus-node-exporter.service
/usr/share/doc/golang-github-prometheus-node-exporter/examples/systemd/
node_exporter.service
So the why is that it puts the service file in the right place.
That leaves the impact of the fix.
Barry
6:28 a.m.
On Fri, Jan 28, 2022 at 12:01:43PM +0000, Barry Scott wrote:
I just had to fix a number of my servers that use node exporter.
The service name has been changed. Why was this done and did no one
think about the impact on users?
This was done here:
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter...
as part of the fix for
https://bugzilla.redhat.com/show_bug.cgi?id=2039257
(golang-github-prometheus-node-exporter installs service unit in /etc)
Moving the unit is fine, but rename should not happen stable release.
At least some compat symlinks/Alias= should be provided.
In the worst case I had a server fail to reboot because I had
Requires=node_exporter.service in the default target.
It is unfortunate. It is also unfortunate no-one cared enough about
node-exporter to have it tested during 2 weeks time
(https://bodhi.fedoraproject.org/updates/FEDORA-2022-e52d3d8db2)
before it was submitted to stable.
--
Tomasz Torcz “Never underestimate the bandwidth of a station
tomek(a)pipebreaker.pl wagon filled with backup tapes.” — Jim Gray
7:18 a.m.
On 28 Jan 2022, at 12:28, Tomasz Torcz <tomek(a)pipebreaker.pl>
wrote:
On Fri, Jan 28, 2022 at 12:01:43PM +0000, Barry Scott wrote:
> I just had to fix a number of my servers that use node exporter.
>
> The service name has been changed. Why was this done and did no one
> think about the impact on users?
This was done here:
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter...
as part of the fix for
https://bugzilla.redhat.com/show_bug.cgi?id=2039257
(golang-github-prometheus-node-exporter installs service unit in /etc)
Moving the unit is fine, but rename should not happen stable release.
At least some compat symlinks/Alias= should be provided.
> In the worst case I had a server fail to reboot because I had
> Requires=node_exporter.service in the default target.
It is unfortunate. It is also unfortunate no-one cared enough about
node-exporter to have it tested during 2 weeks time
(https://bodhi.fedoraproject.org/updates/FEDORA-2022-e52d3d8db2)
before it was submitted to stable.
I guess what is surprising me is that it's a breaking change and that was not
noticed in review or dev testing.
I have now updated golong-github-prometheus that has more breaking changes to handle.
The change in the way that .service file handles arguments is welcome.
But its not compatible with the previous .service files handling.
Barry
9:33 a.m.
On 1/28/22 14:18, Barry Scott wrote:
> On 28 Jan 2022, at 12:28, Tomasz Torcz <tomek(a)pipebreaker.pl> wrote:
>
> On Fri, Jan 28, 2022 at 12:01:43PM +0000, Barry Scott wrote:
>> I just had to fix a number of my servers that use node exporter.
>>
>> The service name has been changed. Why was this done and did no one
>> think about the impact on users?
>
> This was done here:
>
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter...
>
> as part of the fix for
> https://bugzilla.redhat.com/show_bug.cgi?id=2039257
> (golang-github-prometheus-node-exporter installs service unit in /etc)
>
> Moving the unit is fine, but rename should not happen stable release.
> At least some compat symlinks/Alias= should be provided.
>
>> In the worst case I had a server fail to reboot because I had
>> Requires=node_exporter.service in the default target.
>
> It is unfortunate. It is also unfortunate no-one cared enough about
> node-exporter to have it tested during 2 weeks time
> (https://bodhi.fedoraproject.org/updates/FEDORA-2022-e52d3d8db2)
> before it was submitted to stable.
I guess what is surprising me is that it's a breaking change and that was not
noticed in review or dev testing.
I have now updated golong-github-prometheus that has more breaking changes to handle.
The change in the way that .service file handles arguments is welcome.
But its not compatible with the previous .service files handling.
Barry
Hello,
I'm sorry, this is entirely my fault. I provided symlinks for the
binaries, but didn't think of the systemd unit files symlinks. The
services files were added or modified to take into account environment
files which were requested multiple times, and without which the package
were basically unusable. The binary were renamed to provide
commonalities with other distro.
Alert manager service was added, Node exporter and Prometheus were
fixed. There should not be any breaking change for Prometheus though,
the only thing added was the Environment file.
I will seek co-maintainers for these packages as I initially packaged
them to be used as dependency for other projects but I never intended to
be maintainer of the services, which are a bit out of my depth.
I will be pushing an update for node-exporter with a service symlink for
the old name.
11:06 a.m.
On 28 Jan 2022, at 15:33, Robert-André Mauchin
<zebob.m(a)gmail.com> wrote:
Hello,
I'm sorry, this is entirely my fault. I provided symlinks for the binaries, but
didn't think of the systemd unit files symlinks. The services files were added or
modified to take into account environment files which were requested multiple times, and
without which the package were basically unusable. The binary were renamed to provide
commonalities with other distro.
Alert manager service was added, Node exporter and Prometheus were fixed. There should
not be any breaking change for Prometheus though, the only thing added was the Environment
file.
I will seek co-maintainers for these packages as I initially packaged them to be used as
dependency for other projects but I never intended to be maintainer of the services, which
are a bit out of my depth.
I will be pushing an update for node-exporter with a service symlink for the old name.
You can add me as co-maintainer. I'm happy to review any future changes
and discuss packing issues.
Also I like that you have made important improvement to the packaging.
I was working around the problems with being able to pass args to the
prometheus and node-exported command lines.
I found that you made another breaking changes.
You changed the UID/GID for node_exporter's text-collector folder from
node_exporter to prometheus. I'm not convinced that is a useful change.
I was running processes that write to that folder Group=node_exporter.
Now I have to use Group=prometheus and that seems wrong to me.
Why can my collector also access prometheus resources via Group permissions?
Isn't it better that node_exporter and prometheus are keep apart?
Barry
812
days inactive
819
days old
5 comments
3 participants
participants (3)
-
Barry Scott -
Robert-André Mauchin -
Tomasz Torcz