f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
[1] https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&component=fedora-... [2] https://pagure.io/FedoraReview/issues [3] https://pagure.io/FedoraReview/pull-requests [4] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal
On Thu, Aug 16, 2018 at 11:34 AM Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl wrote:
f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
If noboby else wants to volunteer, I can look into starting to bring fedora-review up to speed again. We talked about getting involved in the project more directly in a past FPC meeting - which should also lead to more up-to-date Packaging Guidelines checks.
Fabio FAS: decathorpe
[1] https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&component=fedora-... [2] https://pagure.io/FedoraReview/issues [3] https://pagure.io/FedoraReview/pull-requests [4] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
On 16.8.2018 13:38, Fabio Valentini wrote:
On Thu, Aug 16, 2018 at 11:34 AM Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl wrote:
f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
If noboby else wants to volunteer, I can look into starting to bring fedora-review up to speed again. We talked about getting involved in the project more directly in a past FPC meeting - which should also lead to more up-to-date Packaging Guidelines checks.
Put me in as well. I have no idea how much time would I have, but I can at least help with code reviews.
On Thu, Aug 16, 2018 at 8:34 AM Miro Hrončok mhroncok@redhat.com wrote:
On 16.8.2018 13:38, Fabio Valentini wrote:
On Thu, Aug 16, 2018 at 11:34 AM Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl wrote:
f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
If noboby else wants to volunteer, I can look into starting to bring fedora-review up to speed again. We talked about getting involved in the project more directly in a past FPC meeting - which should also lead to more up-to-date Packaging Guidelines checks.
Put me in as well. I have no idea how much time would I have, but I can at least help with code reviews.
I can try to help where I can, too.
On Thu, Aug 16, 2018 at 10:49 AM Zbigniew Jędrzejewski-Szmek < zbyszek@in.waw.pl> wrote:
f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
I was thinking about getting the fedora-review checks rewritten into the standard Test interface ( https://qa.fedoraproject.org/docs/libtaskotron/latest/standard-test-interfac...) so that they can be run in Taskotron. We can also just probably run one big fedora-review check from a taskotron test, well, this just came to my mind recently, getting the actual solution ready might take a little bit of time.
[1] https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&component=fedora-... [2] https://pagure.io/FedoraReview/issues [3] https://pagure.io/FedoraReview/pull-requests [4] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
On Thu, Aug 16, 2018 at 2:31 PM Michal Novotny clime@redhat.com wrote:
On Thu, Aug 16, 2018 at 10:49 AM Zbigniew Jędrzejewski-Szmek < zbyszek@in.waw.pl> wrote:
f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
I was thinking about getting the fedora-review checks rewritten into the standard Test interface ( https://qa.fedoraproject.org/docs/libtaskotron/latest/standard-test-interfac...) so that they can be run in Taskotron. We can also just probably run one big fedora-review check from a taskotron test, well, this just came to my mind recently, getting the actual solution ready might take a little bit of time.
I was actually thinking about this some time ago. If there's a responsive fedora-review maintainer who can respond to people's questions and complains (because if we start running it for every package build and show it in Bodhi, there will be some), I can help to make it run as a Taskotron task. The STI can be just a simple wrapper around the fedora-review binary that downloads the build, runs the command, and generates the results format. It should be similar to rpmlint etc tests we already have in there.
The important question is - can it be executed on existing SRPMs/RPMs? We don't want to (and probably can't afford to) build the packages from scratch inside Taskotron tasks. But we could run an analysis on an already completed Koji build.
I was actually thinking about this some time ago. If there's a responsive fedora-review maintainer who can respond to people's questions and complains (because if we start running it for every package build and show it in Bodhi, there will be some), I can help to make it run as a Taskotron task. The STI can be just a simple wrapper around the fedora-review binary that downloads the build, runs the command, and generates the results format. It should be similar to rpmlint etc tests we already have in there.
The important question is - can it be executed on existing SRPMs/RPMs?
Yes, somehow. It has --no-build option, but it searches the package in some mock location. Should be fairly easy to change or fake.
On Thu, Aug 16, 2018 at 3:47 PM Miro Hrončok mhroncok@redhat.com wrote:
I was actually thinking about this some time ago. If there's a responsive fedora-review maintainer who can respond to people's questions and complains (because if we start running it for every package build and show it in Bodhi, there will be some), I can help to make it run as a Taskotron task. The STI can be just a simple wrapper around the fedora-review binary that downloads the build, runs the command, and generates the results format. It should be similar to rpmlint etc tests we already have in there.
The important question is - can it be executed on existing SRPMs/RPMs?
Yes, somehow. It has --no-build option, but it searches the package in some mock location. Should be fairly easy to change or fake.
In man pages, there is also a tutorial how to do that with koji scratch builds:
· Download the results: koji-download-scratch <task number>
· Invoke fedora-review using --prebuilt, --name options and --rpm-spec: fedora-review --rpm-spec --prebuilt --name my-package
For copr builds it is a little bit easier:
fedora-review --copr-build <build-id>
But that version of fedora-review still needs was never released (https://pagure.io/FedoraReview/commits/devel)
-- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
On jeudi 16 août 2018 10:47:05 CEST Zbigniew Jędrzejewski-Szmek wrote:
f-r currently fails to build (#1603956), it has a bunch of bugs open [1] and many issues and unhandled pull requests in the upstream repo [2, 3]. The last upstream commit was 2 years ago.
f-r has is annoyingly outdated and gives often outright bad advice (for example about BR:gcc or BR:g++). The situation would be significantly improved if the outstanding PRs were merged.
f-r is also python2-only now, which will be a problem soon since support for python2 is waning [4].
Is there any hope of upstream and downstream activity on f-r?
I sent numerous PR upstream to update its functionality.
I maintain my own patched version on COPR: https://copr.fedorainfracloud.org/coprs/eclipseo/fedora-review/
-
Fabio Valentini -
Kamil Paral -
Michal Novotny -
Miro Hrončok -
Neal Gompa -
Robert-André Mauchin -
Zbigniew Jędrzejewski-Szmek