On 02/10/2010 05:59 PM, Till Maas wrote:
Author: till
Update of /cvs/pkgs/rpms/gpscorrelate/devel In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv9787
Modified Files: gpscorrelate.spec Added Files: gpscorrelate-1.6.0-stdc++.patch Log Message:
- Wed Feb 10 2010 Till Maasopensource@till.name - 1.6.0-5
- Fix build failure due to https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
gpscorrelate-1.6.0-stdc++.patch: Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- NEW FILE gpscorrelate-1.6.0-stdc++.patch --- diff -up gpscorrelate-1.6.0/Makefile.stdc++ gpscorrelate-1.6.0/Makefile --- gpscorrelate-1.6.0/Makefile.stdc++ 2010-02-10 17:48:00.316933435 +0100 +++ gpscorrelate-1.6.0/Makefile 2010-02-10 17:48:05.044936249 +0100 @@ -7,7 +7,7 @@ GOBJS = main-gui.o gui.o unixtime.o g CFLAGS = -Wall override CFLAGS += $(shell pkg-config --cflags libxml-2.0 gtk+-2.0) -I/usr/include/exiv2 OFLAGS = -Wall -override OFLAGS += $(shell pkg-config --libs libxml-2.0 gtk+-2.0) -lm -lexiv2 +override OFLAGS += $(shell pkg-config --libs libxml-2.0 gtk+-2.0) -lm -lexiv2 -lstdc++ prefix = /usr/local bindir = $(prefix)/bin datadir = $(prefix)/share
This patch is wrong.
The actual bug this package suffers from is using "gcc" to link c++ code.
C++ code MUST be linked with "g++", using "gcc" is not right. The fact your package might compile without complaint with -lstdc++ is just a lucky random coincidence, but is not a real fix.
Ralf
On Wed, Feb 10, 2010 at 06:12:06PM +0100, Ralf Corsepius wrote:
This patch is wrong.
The actual bug this package suffers from is using "gcc" to link c++ code.
C++ code MUST be linked with "g++", using "gcc" is not right. The fact your package might compile without complaint with -lstdc++ is just a lucky random coincidence, but is not a real fix.
I am impressed, that you spotted this. The fix is added to gpscorrelate-1_6_0-6_fc13.
Thanks Till