I got email today telling me that this update can be pushed stable now:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-6960d09c20
Question 1: why is that? The update needs to be in testing for 7 days or receive karma of 3 or more. It has been in testing for 4 days and has karma of 2. Why is it eligible to be pushed stable?
I submitted these two updates on Thursday and Friday, respectively:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5 https://bodhi.fedoraproject.org/updates/FEDORA-2020-6994abfc21
They are still in the pending state, while an update I submitted on Saturday has since been pushed to testing. Question 2: Is something blocking these two updates?
Thanks,
On Mon, Nov 16, 2020, 16:54 Jerry James loganjerry@gmail.com wrote:
I got email today telling me that this update can be pushed stable now:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-6960d09c20
Question 1: why is that? The update needs to be in testing for 7 days or receive karma of 3 or more. It has been in testing for 4 days and has karma of 2. Why is it eligible to be pushed stable?
Normal updates need at *least* +2 karma so they can be pushed to stable *manually*. The default of +3 karma only makes bodhi push updates to stable *earlier* automatically, instead of after 7 days.
I submitted these two updates on Thursday and Friday, respectively:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5 https://bodhi.fedoraproject.org/updates/FEDORA-2020-6994abfc21
They are still in the pending state, while an update I submitted on Saturday has since been pushed to testing. Question 2: Is something blocking these two updates?
No. Just push the "Actions" Button and then click "Push to testing" in the dropdown. They were created from side tags I assume (?), where bodhi doesn't push updates to "testing" automatically (this is a bug, I assume).
Fabio
Thanks,
Jerry James http://www.jamezone.org/ _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
On Mon, Nov 16, 2020 at 9:09 AM Fabio Valentini decathorpe@gmail.com wrote:
Normal updates need at *least* +2 karma so they can be pushed to stable *manually*. The default of +3 karma only makes bodhi push updates to stable *earlier* automatically, instead of after 7 days.
Gotcha. Somehow I've missed that all this time.
No. Just push the "Actions" Button and then click "Push to testing" in the dropdown. They were created from side tags I assume (?), where bodhi doesn't push updates to "testing" automatically (this is a bug, I assume).
Yes, they were created from side tags. I did expect them to be pushed to testing automatically. I have now adjusted my expectations, but that's pretty nonintuitive. Why would I want to create an update that goes nowhere?
Thanks, Fabio. You're a life saver.
On Mon, Nov 16, 2020 at 5:14 PM Jerry James loganjerry@gmail.com wrote:
On Mon, Nov 16, 2020 at 9:09 AM Fabio Valentini decathorpe@gmail.com wrote:
Normal updates need at *least* +2 karma so they can be pushed to stable *manually*. The default of +3 karma only makes bodhi push updates to stable *earlier* automatically, instead of after 7 days.
Gotcha. Somehow I've missed that all this time.
It has confused me as well. For context: https://github.com/fedora-infra/bodhi/issues/3842
I think the text in the UI is just misleading. I guess it should say something like "This update now fulfils the necessary requirements to be pushed to stable manually early"
No. Just push the "Actions" Button and then click "Push to testing" in the dropdown. They were created from side tags I assume (?), where bodhi doesn't push updates to "testing" automatically (this is a bug, I assume).
Yes, they were created from side tags. I did expect them to be pushed to testing automatically. I have now adjusted my expectations, but that's pretty nonintuitive. Why would I want to create an update that goes nowhere?
Looks like this was fixed, but it's not deployed yet: https://github.com/fedora-infra/bodhi/issues/4087
Thanks, Fabio. You're a life saver.
Ah, I'm just sharing my wisdom. It has no use when I keep it to myself :)
Fabio
On Mon, Nov 16, 2020 at 9:34 AM Fabio Valentini decathorpe@gmail.com wrote:
Ah, I'm just sharing my wisdom. It has no use when I keep it to myself :)
I need a little more wisdom. This is the update I created from the side tag:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5/
A tester found a problem with the sagemath package, so I did a new build (also into the side tag), sagemath-9.2-2.fc33. Now I want to edit the update. I click the edit button ... and the list of builds is not editable. Is that intentional? If so, how am I supposed to update an update?
Il 18/11/20 18:43, Jerry James ha scritto:
On Mon, Nov 16, 2020 at 9:34 AM Fabio Valentini decathorpe@gmail.com wrote:
Ah, I'm just sharing my wisdom. It has no use when I keep it to myself :)
I need a little more wisdom. This is the update I created from the side tag:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5/
A tester found a problem with the sagemath package, so I did a new build (also into the side tag), sagemath-9.2-2.fc33. Now I want to edit the update. I click the edit button ... and the list of builds is not editable. Is that intentional? If so, how am I supposed to update an update?
Yeah, that's another Bodhi webUI bug (fixed in devel, but not yet available in prod).
To update the builds list of a side-tag update you can use the CLI: `bodhi updates edit --from-tag=<side-tag> <update-alias>`
Try that...
Mattia
On Wed, Nov 18, 2020 at 10:56 AM Mattia Verga via devel devel@lists.fedoraproject.org wrote:
Yeah, that's another Bodhi webUI bug (fixed in devel, but not yet available in prod).
To update the builds list of a side-tag update you can use the CLI: `bodhi updates edit --from-tag=<side-tag> <update-alias>`
Try that...
$ bodhi updates edit --from-tag=f33-build-side-33909 FEDORA-2020-f16abf2fb5 Error: --from-tag option does not take a value $ bodhi updates edit --from-tag FEDORA-2020-f16abf2fb5 ERROR: The release of the update is composed by Bodhi, i.e. follows the normal update workflow. Please build packages normally, using build root overrides as required, and edit the update accordingly with these new builds. $ bodhi updates edit --addbuilds sagemath-9.2-2.fc33 --removebuilds sagemath-9.2-1.fc33 FEDORA-2020-f16abf2fb5 Cannot find release associated with build: sagemath-9.2-2.fc33, tags: ['f33-build-side-33909']
/me bangs head against handy brick wall
On Wed, Nov 18, 2020 at 11:05:04AM -0700, Jerry James wrote:
On Wed, Nov 18, 2020 at 10:56 AM Mattia Verga via devel devel@lists.fedoraproject.org wrote:
Yeah, that's another Bodhi webUI bug (fixed in devel, but not yet available in prod).
To update the builds list of a side-tag update you can use the CLI: `bodhi updates edit --from-tag=<side-tag> <update-alias>`
Try that...
$ bodhi updates edit --from-tag=f33-build-side-33909 FEDORA-2020-f16abf2fb5 Error: --from-tag option does not take a value $ bodhi updates edit --from-tag FEDORA-2020-f16abf2fb5 ERROR: The release of the update is composed by Bodhi, i.e. follows the normal update workflow. Please build packages normally, using build root overrides as required, and edit the update accordingly with these new builds. $ bodhi updates edit --addbuilds sagemath-9.2-2.fc33 --removebuilds sagemath-9.2-1.fc33 FEDORA-2020-f16abf2fb5 Cannot find release associated with build: sagemath-9.2-2.fc33, tags: ['f33-build-side-33909']
/me bangs head against handy brick wall
HUmf. I also tried without much luck... (and I unpushed it as part of that, sorry for that).
Can you file a releng ticket on this and we can at the very least dig into the database and fix it that way. ;(
kevin
On Wed, Nov 18, 2020 at 3:47 PM Kevin Fenzi kevin@scrye.com wrote:
HUmf. I also tried without much luck... (and I unpushed it as part of that, sorry for that).
No problem. Thank you for trying.
Can you file a releng ticket on this and we can at the very least dig into the database and fix it that way. ;(
https://pagure.io/releng/issue/9857
Regards,
Fabio Valentini wrote:
Normal updates need at *least* +2 karma so they can be pushed to stable *manually*.
Uh, last I checked, normal updates need only +1 (and that's a good thing, many updates don't even get +1 in a reasonable time frame, let alone +2). Only critical path packages and (IIRC) EPEL need +2.
Kevin Kofler
On Tue, Nov 17, 2020 at 1:25 PM Kevin Kofler via devel devel@lists.fedoraproject.org wrote:
Fabio Valentini wrote:
Normal updates need at *least* +2 karma so they can be pushed to stable *manually*.
Uh, last I checked, normal updates need only +1 (and that's a good thing, many updates don't even get +1 in a reasonable time frame, let alone +2). Only critical path packages and (IIRC) EPEL need +2.
You are kinda right, yet you are not. The minimum for *autokarma* is +1 for normal updates, +2 for critpath updates. But the message "This update can be pushed to stable if the maintainer wishes" does not refer to autokarma (update getting pushed automatically by bodhi after getting the necessary karma), but to maintainers pushing an update *manually* - which is *always* allowed for updates that got at least +2 karma, and is independent from "autokarma".
Fabio
Fabio Valentini wrote:
You are kinda right, yet you are not. The minimum for *autokarma* is +1 for normal updates, +2 for critpath updates. But the message "This update can be pushed to stable if the maintainer wishes" does not refer to autokarma (update getting pushed automatically by bodhi after getting the necessary karma), but to maintainers pushing an update *manually* - which is *always* allowed for updates that got at least +2 karma, and is independent from "autokarma".
Well, for my updates, I normally disable autopush *and* set the stable threshold to 1 (why would I want it set any higher? With manual push, I can still decide to wait for more feedback if the +1 does not convince me, I do not need Bodhi to enforce that for me), and then Bodhi correctly gives me that "This update can be pushed to stable if the maintainer wishes" notification when the update gets +1 karma (unless this regressed recently).
Kevin Kofler