Recently we've had a new automation introduced, which seeks out stalled review requests and tries to prod them to move forward.
One of the ways it does this is by looking at reviews which have the NEEDINFO flag set and, if the ticket reviewer failed to reply for a long time, it resets the ticket status and assignee. This allows someone else to take over the review.
However, as witnessed here [1], there is a bug in the automation, causing it to spam a ticket endlessly. Guessing by that thread, the cause of this seems to be: a) failing to check if the NEEDINFO flag is set for the *submitter*, instead of a reviewer b) failing to clear the NEEDINFO flag for the submitter
Since the NEEDINFO flag is not cleared, the next time the automation stumbles across the ticket, all the conditions required for it to take action and post a message are still there.
a) failing to check if the NEEDINFO flag is set for the *submitter*, instead of a reviewer b) failing to clear the NEEDINFO flag for the submitter
Oops, I barely posted the message and I already spotted that I'm wrong.
The NEEDINFO flag, in this case, is set to require action from "nobody@fedoraproject.org". The ticket never had an assignee specified; which basically makes "nobody@fedoraproject.org" the assignee. Yet the NEEDINFO flag is still not cleared.
Il 16/11/20 09:29, Artur Frenszek-Iwicki ha scritto:
a) failing to check if the NEEDINFO flag is set for the *submitter*, instead of a reviewer b) failing to clear the NEEDINFO flag for the submitter
Oops, I barely posted the message and I already spotted that I'm wrong.
The NEEDINFO flag, in this case, is set to require action from "nobody@fedoraproject.org". The ticket never had an assignee specified; which basically makes "nobody@fedoraproject.org" the assignee. Yet the NEEDINFO flag is still not cleared.
Yeah, it's a bug, thanks for pointing that out. I'll fix it, for the moment I'll remove that odd needinfo flag.
Mattia
-
Artur Frenszek-Iwicki -
Mattia Verga