Re: Review Request 71: Enable logging of subprocess output

On Srp. 20, 2014, 1:18 odp., Miloslav Trmac wrote: > src/rolekit/async.py, lines 232-234 > <http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/1/?file=281#file281... > > for line in lines[:-1]: log_fn(line)

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/71/ ----------------------------------------------------------- (Updated Srp. 20, 2014, 4:05 dop.) Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- In the original approach, it was impossible to monitor the progress of a subprocess because all of the stdout/stderr was being buffered for retrieval only after the process exited. With this patch, we will now drop stdout into log.debug1() and stderr into log.error() as they come in (in addition to storing the complete results for retrieval later). This will make debugging efforts much simpler. Diffs ----- src/rolekit/async.py 8a3dfdcf8f86fa0d475d4f95d7dd7aa45a40517f Diff: http://reviewboard-fedoraserver.rhcloud.com/r/71/diff/ Testing ------- Testing was performed alongside the Domain Controller deployment. With this patch, I was able to see how far along the deployment had gotten. Thanks, Stephen Gallagher