----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/#review257 ----------------------------------------------------------- The patch looks sane to me by inspection, but I can't apply it on the current master branch. Could you please rebase it atop the domain controller patches (since these will likely all land at the same time). - Stephen Gallagher On Aug. 18, 2014, 3:02 p.m., Thomas Woerner wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/#review268 ----------------------------------------------------------- This code isn't working at all. I attempted to do a deploy() of the domain controller with this patch attached and hit an unhandled exception: <type 'exceptions.KeyError'>: 'firewall-changes' Trying to decommission it, I hit the same exception. I also see Error: ALREADY_ENABLED: 'freeipa-ldap' already in 'FedoraServer' if I try to deploy again (this happens before it notices that the instance count is exceeded as well). - Stephen Gallagher On Aug. 22, 2014, 6:57 p.m., Thomas Woerner wrote:

This is fixed now. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/#review268 ----------------------------------------------------------- On Aug. 22, 2014, 6:57 p.m., Thomas Woerner wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/69/ ----------------------------------------------------------- (Updated Oct. 2, 2014, 1:43 p.m.) Status ------ This change has been marked as submitted. Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- installFirewall uses the firewall _settings from the role: firewall and firewall_zones and stores the applied settings in _settings per zone and also for the runtime and permanant firewalld environment. uninstallFirewall uses the fw_changes _setting from the role and removed them from the zones in runtime and permanent firewalld environment, then clears fw_changes and savet it to _settings again. updateFirewall calls uninstallFirewall and then installFirewall _check_property now checks ports to be valid. Diffs ----- src/rolekit/server/rolebase.py 95b10c62ff44fbf12d96992bb07fc68d156259ca Diff: http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/ Testing ------- Thanks, Thomas Woerner