----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/#review62 ----------------------------------------------------------- After calling the error handler the code continues, this needs to be fixed. Please also have a look at reply handler usage... - Thomas Woerner On July 22, 2014, 1:40 a.m., Stephen Gallagher wrote:

This one is ok, since it is at the end of the function and the return value is ignored, but you're right that it should be explicit. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/#review63 ----------------------------------------------------------- On July 22, 2014, 1:40 a.m., Stephen Gallagher wrote:

Good point. This is kind of a holdover from the fact that I was allowing the sync behavior to use the async callbacks. I'm going to finish the async all the way down to do_deploy() which will eliminate this. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/#review64 ----------------------------------------------------------- On July 22, 2014, 1:40 a.m., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/ ----------------------------------------------------------- (Updated July 22, 2014, 2:09 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Changes ------- Added the explicit 'return' keywords and moved the reply/error_handler into the role.deploy() routine. Repository: rolekit Description ------- This patch passes two callbacks, reply_handler and error_handler into the deploy() methods. We can pass these handlers down into asynchronous functions to allow us to avoid blocking on long- waiting routines. This patch prepares the system for async operation but the call to do_deploy() in the rolebase is still synchronous. Diffs (updated) ----- src/rolekit/server/dbusrole.py 6cef7cfeba6a7bbe396601c7ab31fe034757bc6a src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/18/diff/ Testing ------- I used d-feet to test the deploy() method on the testrole. It behaves as it used to. Thanks, Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/ ----------------------------------------------------------- (Updated July 22, 2014, 7:45 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Changes ------- Rebased atop the latest master branch Repository: rolekit Description ------- This patch passes two callbacks, reply_handler and error_handler into the deploy() methods. We can pass these handlers down into asynchronous functions to allow us to avoid blocking on long- waiting routines. This patch prepares the system for async operation but the call to do_deploy() in the rolebase is still synchronous. Diffs (updated) ----- src/rolekit/server/dbusrole.py 6cef7cfeba6a7bbe396601c7ab31fe034757bc6a src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/18/diff/ Testing ------- I used d-feet to test the deploy() method on the testrole. It behaves as it used to. Thanks, Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/18/#review137 ----------------------------------------------------------- See #44 for an alternative. - Miloslav Trmac On Čec. 22, 2014, 9:45 odp., Stephen Gallagher wrote: