Applied. Sorry for the delay, I'll push this into production ASAP.
luke
On Tue, Dec 14, 2010 at 09:04:47PM +0100, François Cami wrote:
Hello Luke, test@, bodhi@,
On Sun, Dec 5, 2010 at 6:22 AM, Kevin Fenzi <kevin(a)scrye.com> wrote:
> On Sat, 4 Dec 2010 17:56:42 +0100
> François Cami <fdc-lists(a)fcami.net> wrote:
>
>> The following patch tentatively changes the message bodhi posts to
>> bugzilla when a build is tagged as an update candidate to make clear
>> that we expect bug reporters to post their feedbacks on updates in the
>> bodhi instance.
>> Please review the message - I am sure someone can make it better.
>
> See also:
>
>
https://fedorahosted.org/fedora-infrastructure/ticket/701
I have attached a refined version of the patch to this email, that
hopefully takes into account all the feedboack from Monday's QA
meeting.
I don't think this is a perfect solution and it clearly does not solve
all the issues listed in the afore-mentioned ticket but should still
incite bug reporters to post feedback / karma.
Cheers
François
From 8a0bff89f87452a6e8231ef6612f05f5c0be1869 Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fcami(a)fedoraproject.org>
Date: Tue, 14 Dec 2010 19:00:59 +0100
Subject: [PATCH] ask bug reporters to test updates and post karma
---
bodhi/controllers.py | 30 ++++++++++++++++++++++++------
1 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/bodhi/controllers.py b/bodhi/controllers.py
index f323291..9456ad1 100644
--- a/bodhi/controllers.py
+++ b/bodhi/controllers.py
@@ -971,9 +971,18 @@ class Root(controllers.RootController):
log.debug("Updating newly added bug: %s" % bug)
try:
Bugzilla.byBz_id(bug).add_comment(update,
- "%s has been submitted as an update for
%s.\n%s" %
- (update.title, release.long_name,
- config.get('base_address') +
tg_url(update.get_url())))
+ "Package %s:\n"
+ "* should fix your issue,\n"
+ "* was pushed to the %s updates-testing
repository,\n"
+ "* should be available at your local mirror within
two days.\n"
+ "Update it with:\n"
+ "# su -c 'yum update
--enablerepo=updates-testing %s'\n"
+ "as soon as you are able to, then reboot.\n"
+ "Please go to the following url:\n"
+ "%s\n"
+ "then log in and leave karma (feedback)." %
+ (update.title, release.long_name, update.title,
+ config.get('base_address') +
tg_url(update.get_url())))
except SQLObjectNotFound:
log.debug('Bug #%d not found in our database' %
bug)
@@ -992,9 +1001,18 @@ class Root(controllers.RootController):
# Comment on all bugs
for bug in update.bugs:
bug.add_comment(update,
- "%s has been submitted as an update for %s.\n%s" %
- (update.title, release.long_name,
- config.get('base_address') +
tg_url(update.get_url())))
+ "Package %s:\n"
+ "* should fix your issue,\n"
+ "* was pushed to the %s updates-testing
repository,\n"
+ "* should be available at your local mirror within two
days.\n"
+ "Update it with:\n"
+ "# su -c 'yum update --enablerepo=updates-testing
%s'\n"
+ "as soon as you are able to, then reboot.\n"
+ "Please go to the following url:\n"
+ "%s\n"
+ "then log in and leave karma (feedback)." %
+ (update.title, release.long_name, update.title,
+ config.get('base_address') +
tg_url(update.get_url())))
# If a request is specified, make it. By default we're submitting
# new updates directly into testing
--
1.7.3.3
_______________________________________________
bodhi mailing list
bodhi(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/bodhi