Gagadget wrote: > Dear listers, > > BIND has a version numbering system like this : > Major.Medium.Minor-Ppatchlevel, with -Ppatchlevel only exists if patchlevel > > 0. For instance, the source are named like that : > > bind-9.5.2-P2.tar.gz > bind-9.6.0-P1.tar.gz > bind-9.2.9.tar.gz > > I try to define a generic spec file for BIND packaging, here is what I did > : > > %define VERSION 9.6.0 > This define is redundant and unnecessary. Just put the version directly in the "Version:" tag, and rpm does the right thing. Version: 9.6.0

-- Fedora-packaging mailing list Fedora-packaging(a)redhat.com https://www.redhat.com/mailman/listinfo/fedora-packaging

Gagadget <gagadget(a)gmail.com&gt; writes: > %define VERSION 9.6.0 > %define PATCHVER 1 > [ ... ] > %if %{PATCHVER} > Source0: > ftp://ftp.isc.org/isc/bind9/%{VERSION}-P%{PATCHVER}/bind-%{VERSION}-P%{PA... > %else > Source0: > ftp://ftp.isc.org/isc/bind9/%{VERSION}/bind-%{VERSION}.tar.gz<ftp://ft... > %endif > > It works, but I'd like to know if there is a more recursive way to avoid > if/else ? Using "?" macro or something like that ? %global XVER %VERSION%{?PATCHVER:-P%PATCHVER} Source0: ftp://ftp.isc.org/isc/bind9/%XVER/bind-%XVER.tar.gz and do not define 'PATCHVER 0'

Enrico -- Fedora-packaging mailing list Fedora-packaging(a)redhat.com https://www.redhat.com/mailman/listinfo/fedora-packaging

Gagadget wrote: > Thank you, here is what I did : > > %define VERSION 9.6.0 > %define PATCHVER 1 > %define DISTVER mylocaldist > %define PKGVER 1 > [...] > Version: %{VERSION} Since you are not using the "-" in the version, you can remove the %define VERSION 9.6.0 and just use: Version: 9.6.0 Then future references to version will be %{version} > Release: %{?PATCHVER:P%PATCHVER.}%{DISTVER}.%{PKGVER} > [...] > Source0: > ftp://ftp.isc.org/isc/bind9/%{VERSION}%{?PATCHVER:-P%PATCHVER}/bind-%{VER... > [...] > %prep > %setup -q -n %{name}-%{VERSION}%{?PATCHVER:-P%PATCHVER} > > I can't define a BINDVER or XVER because I want to have the Patchlevel > in the Release tag, and it refuse the "-". With the above, my rpm is > named bind-9.6.0-P1.mylocaldist.1 > > One question : > > If i do > # %define PATCHVER 1 > > The PATCHVER is still define, I have to delete it to get it work ??? Is > it normal ? > Yes. macros are expanded even in comments. You can do this instead: # %%define PATCHVER 1

-Toshio -- Fedora-packaging mailing list Fedora-packaging(a)redhat.com https://www.redhat.com/mailman/listinfo/fedora-packaging