On Fri, 31 May 2019 20:32:24 +0100 Phil Wyett
<philwyett(a)kathenas.org
> wrote:
> On Fri, 2019-05-31 at 13:24 -0500, Ranjan Maitra wrote:
> > On Fri, 31 May 2019 19:58:04 +0200 Franta Hanzlík <
> > franta(a)hanzlici.cz
> > > wrote:
> > > On Wed, 29 May 2019 18:06:19 -0500
> > > Ranjan Maitra <maitra(a)email.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > I have the following specfile which compiled fine in F29 but
> > > > is
> > > > not able to find references to standard functions in X11, etc
> > > > even though the compilation happens without error (outside
> > > > the
> > > > rpmbuild environment). So I am wondering if anyone has some
> > > > suggestions on what has changed/is going wrong.
> > > >
> > > > Here is the spec file:
> > > >
> > > > $ fpaste thaali.spec
> > > > Uploading (1.4KiB)...
> > > >
https://paste.fedoraproject.org/paste/3sHHnOdGoM4YHmdzzJRzgQ
> > > >
> > > >
> > > > And here are the messages that I get when I try to build:
> > >
> > > ...
> > >
> > > Just an idea - once I had a problem building a program when the
> > > make
> > > '-j' switch was greater than one. Specifying '-j1' solved
it.
> > > Unfortunately, I don't even remember the cause or how it
> > > manifested
> > > itself...
> > >
> >
> > Thanks! So, I use:
> >
> > %make_build
> >
> > I replaced this with "make -j1" or also with "make -j" or
-j or
> > -j1
> > appended to %make_build.
> >
> > I don't really understand this, but all of them gave errors.
> >
> > Thanks again for your help!
> >
> > Best wishes,
> > Ranjan
> > _______________________________________________
> >
>
> Hi Ranjan,
>
> This is an upstream configure issue.
>
> 1. I took the pastebin spec file.
> 2. Added to spec file: BuildRequires: gcc
> 3. Saw spec file does a reconfigure and looked at upstream
> configure.ac
> 4. Saw it is not correct. Substitute upstream configure.ac for
> below.
>
> // Start
>
> AC_INIT(thaali, 0.4.0)
> AC_CONFIG_SRCDIR(src/thaali.c)
> AM_INIT_AUTOMAKE
>
> AM_CONFIG_HEADER(config.h)
>
> AC_PROG_CC
> AC_PATH_X
> AC_PATH_XTRA
>
> dnl Are we going to enable the debugging output ??
> AC_ARG_ENABLE(debug,
> AC_HELP_STRING([--enable-debug], [Enable runtime debugging
> (default:
> no)]),
> debug=$enableval, debug=no)
>
> if test "$debug" = yes; then
> AC_DEFINE(DEBUG,,[Enable verbose debugging output])
> fi
>
> dnl Let's do some X testing for... ;-)
> if test -n "$x_includes" && test "x$x_includes" != xNONE
; then
> CFLAGS="$CFLAGS -I$x_includes"
> fi
> if test -n "$x_libraries" && test "x$x_libraries" !=
xNONE ; then
> LDFLAGS="$LDFLAGS -L$x_libraries"
> fi
>
> AC_CHECK_LIB([ICE],[IceOpenConnection],,AC_MSG_ERROR([Can't find
> libICE]),)
> AC_CHECK_LIB([SM],[SmcOpenConnection],,AC_MSG_ERROR([Can't find
> libSM]),)
> AC_CHECK_LIB([X11],[XOpenDisplay],,AC_MSG_ERROR([Can't find
> libX11]),
> -L$x_libraries $X_PRE_LIBS)
>
> AC_SUBST(x_includes)
> AC_SUBST(x_libraries)
>
> AC_OUTPUT([
> Makefile
> src/Makefile
> ])
>
> // End
>
> Now the RPM builds fine on F30.
>
> Note this was just a hack to get it to build and show it as an
> upstream
> issue. You can diff my changes against original configure.ac. To be
> honest you have some work ahead as this is all very old and out of
> date
> both upstream side and how the spec file is constructed. You will
> need
> to research to fix.
>
> Regards
>
> Phil
Phil,
Thanks very much! I am also "upstream" so I can fix this. But I was
thinking that since you should get the credit, would you like to do a
pull request?
Yes, the file is old. It used to be something called peksystray and I
took it over, "forked" it because the original authors could not be
found, or would not respond to my e-mails (these were pre-github
days), made it more aligned to pedantic standards and renamed it.
It does very well for its one job, that is, to be a dock for
applications like NetworkManager, blueman and other applets and
nothing else. I use it with openbox.
Best wishes,
Ranjan
Hi,
No credit required Ranjan. We try help each other when we can and I am
only too happy to on this occasion.
Regards
Phil
--
*** Playing the game for the games sake. ***
IRC: kathenas
Twitter: kathenasorg
Website: