Ravindra Kumar (ravindrakumar(a)vmware.com) said: > > The two added group are OK. grouplist is not something that actually is > > used, though; they would need to either be added as mandatory/optional > > groups to the desktop environments, or just brought in via the spins' > > kickstart files. > > > Also, please attach patches - your mailer appears to have mangled the > > spacing. > > Thanks Bill for looking at it. Could you please take a look at the new > patch (attached)? Seems initially reasonable, might tweak the names/descriptions a bit (the names need to be distinct). That being said, this would be a string freeze. CC'ing the translation list - OK to add these two groups to comps for F-19?

> --- comps-f19.xml.in 2013-05-10 19:00:24.191468344 -0700 > +++ comps-f19.xml.in.new 2013-05-12 21:49:31.433352612 -0700 > @@ -5633,6 +5633,26 @@ > </packagelist> > </group> > <group> > + <id>virt-agents</id> > + <_name>Virtualization Agents</_name> > + <_description>These packages enable better management of virtual machines.</_description> > + <default>true</default> > + <uservisible>true</uservisible> > + <packagelist> > + <packagereq type="default">open-vm-tools</packagereq> > + </packagelist> > + </group> > + <group> > + <id>virt-agents-x</id> > + <_name>Virtualization Agents</_name> > + <_description>These packages enable better user experience for virtual machines.</_description> > + <default>true</default> > + <uservisible>true</uservisible> > + <packagelist> > + <packagereq type="default">open-vm-tools-desktop</packagereq> > + </packagelist> > + </group> > + <group> > <id>virtualization</id> > <_name>Virtualization</_name> > <_description>These packages provide a virtualization environment.</_description> > @@ -5878,6 +5898,8 @@ > <groupid>hardware-support</groupid> > <groupid>printing</groupid> > <groupid>firefox</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>gnome-desktop</groupid> > </grouplist> > <optionlist> > @@ -5902,6 +5924,8 @@ > <groupid>multimedia</groupid> > <groupid>hardware-support</groupid> > <groupid>printing</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>kde-desktop</groupid> > </grouplist> > <optionlist> > @@ -5928,6 +5952,8 @@ > <groupid>multimedia</groupid> > <groupid>hardware-support</groupid> > <groupid>printing</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>xfce-desktop</groupid> > <groupid>xfce-apps</groupid> > <groupid>xfce-media</groupid> > @@ -5953,6 +5979,8 @@ > <groupid>multimedia</groupid> > <groupid>hardware-support</groupid> > <groupid>printing</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>lxde-desktop</groupid> > </grouplist> > <optionlist> > @@ -5977,6 +6005,8 @@ > <groupid>multimedia</groupid> > <groupid>hardware-support</groupid> > <groupid>printing</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>cinnamon-desktop</groupid> > </grouplist> > <optionlist> > @@ -5998,6 +6028,8 @@ > <groupid>multimedia</groupid> > <groupid>hardware-support</groupid> > <groupid>printing</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>mate-desktop</groupid> > </grouplist> > <optionlist> > @@ -6019,6 +6051,8 @@ > <groupid>input-methods</groupid> > <groupid>multimedia</groupid> > <groupid>hardware-support</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>sugar-desktop</groupid> > </grouplist> > <optionlist> > @@ -6051,6 +6085,8 @@ > <groupid>gnome-software-development</groupid> > <groupid>kde-software-development</groupid> > <groupid>x-software-development</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>virtualization</groupid> > <groupid>web-server</groupid> > </grouplist> > @@ -6084,6 +6120,7 @@ > <groupid>standard</groupid> > <groupid>core</groupid> > <groupid>hardware-support</groupid> > + <groupid>virt-agents</groupid> > <groupid>web-server</groupid> > </grouplist> > <optionlist> > @@ -6108,6 +6145,7 @@ > <groupid>standard</groupid> > <groupid>core</groupid> > <groupid>hardware-support</groupid> > + <groupid>virt-agents</groupid> > </grouplist> > <optionlist> > <groupid>dogtag</groupid> > @@ -6138,6 +6176,8 @@ > <groupid>fonts</groupid> > <groupid>hardware-support</groupid> > <groupid>multimedia</groupid> > + <groupid>virt-agents</groupid> > + <groupid>virt-agents-x</groupid> > <groupid>basic-desktop</groupid> > </grouplist> > <optionlist> > @@ -6163,6 +6203,7 @@ > </grouplist> > <optionlist> > <groupid>standard</groupid> > + <groupid>virt-agents</groupid> > </optionlist> > </environment> > <category> > -- > devel mailing list > devel(a)lists.fedoraproject.org > https://admin.fedoraproject.org/mailman/listinfo/devel -- trans mailing list trans(a)lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/trans

Bill Nottingham (notting(a)redhat.com) said: > Ravindra Kumar (ravindrakumar(a)vmware.com) said: > > > The two added group are OK. grouplist is not something that > actually is > > > used, though; they would need to either be added as > mandatory/optional > > > groups to the desktop environments, or just brought in via the > spins' > > > kickstart files. > > > > > Also, please attach patches - your mailer appears to have mangled > the > > > spacing. > > > > Thanks Bill for looking at it. Could you please take a look at the new > > patch (attached)? > > Seems initially reasonable, might tweak the names/descriptions a bit > (the names need to be distinct). > > That being said, this would be a string freeze. CC'ing the translation > list - OK to add these two groups to comps for F-19? Just checking in - any +1s here?

Bill > > --- comps-f19.xml.in 2013-05-10 19:00:24.191468344 -0700 > > +++ comps-f19.xml.in.new 2013-05-12 21:49:31.433352612 -0700 > > @@ -5633,6 +5633,26 @@ > > </packagelist> > > </group> > > <group> > > + <id>virt-agents</id> > > + <_name>Virtualization Agents</_name> > > + <_description>These packages enable better management of virtual > machines.</_description> > > + <default>true</default> > > + <uservisible>true</uservisible> > > + <packagelist> > > + <packagereq type="default">open-vm-tools</packagereq> > > + </packagelist> > > + </group> > > + <group> > > + <id>virt-agents-x</id> > > + <_name>Virtualization Agents</_name> > > + <_description>These packages enable better user experience for > virtual machines.</_description> > > + <default>true</default> > > + <uservisible>true</uservisible> > > + <packagelist> > > + <packagereq type="default">open-vm-tools-desktop</packagereq> > > + </packagelist> > > + </group> > > + <group> > > <id>virtualization</id> > > <_name>Virtualization</_name> > > <_description>These packages provide a virtualization > environment.</_description> > > @@ -5878,6 +5898,8 @@ > > <groupid>hardware-support</groupid> > > <groupid>printing</groupid> > > <groupid>firefox</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>gnome-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -5902,6 +5924,8 @@ > > <groupid>multimedia</groupid> > > <groupid>hardware-support</groupid> > > <groupid>printing</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>kde-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -5928,6 +5952,8 @@ > > <groupid>multimedia</groupid> > > <groupid>hardware-support</groupid> > > <groupid>printing</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>xfce-desktop</groupid> > > <groupid>xfce-apps</groupid> > > <groupid>xfce-media</groupid> > > @@ -5953,6 +5979,8 @@ > > <groupid>multimedia</groupid> > > <groupid>hardware-support</groupid> > > <groupid>printing</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>lxde-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -5977,6 +6005,8 @@ > > <groupid>multimedia</groupid> > > <groupid>hardware-support</groupid> > > <groupid>printing</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>cinnamon-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -5998,6 +6028,8 @@ > > <groupid>multimedia</groupid> > > <groupid>hardware-support</groupid> > > <groupid>printing</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>mate-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -6019,6 +6051,8 @@ > > <groupid>input-methods</groupid> > > <groupid>multimedia</groupid> > > <groupid>hardware-support</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>sugar-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -6051,6 +6085,8 @@ > > <groupid>gnome-software-development</groupid> > > <groupid>kde-software-development</groupid> > > <groupid>x-software-development</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>virtualization</groupid> > > <groupid>web-server</groupid> > > </grouplist> > > @@ -6084,6 +6120,7 @@ > > <groupid>standard</groupid> > > <groupid>core</groupid> > > <groupid>hardware-support</groupid> > > + <groupid>virt-agents</groupid> > > <groupid>web-server</groupid> > > </grouplist> > > <optionlist> > > @@ -6108,6 +6145,7 @@ > > <groupid>standard</groupid> > > <groupid>core</groupid> > > <groupid>hardware-support</groupid> > > + <groupid>virt-agents</groupid> > > </grouplist> > > <optionlist> > > <groupid>dogtag</groupid> > > @@ -6138,6 +6176,8 @@ > > <groupid>fonts</groupid> > > <groupid>hardware-support</groupid> > > <groupid>multimedia</groupid> > > + <groupid>virt-agents</groupid> > > + <groupid>virt-agents-x</groupid> > > <groupid>basic-desktop</groupid> > > </grouplist> > > <optionlist> > > @@ -6163,6 +6203,7 @@ > > </grouplist> > > <optionlist> > > <groupid>standard</groupid> > > + <groupid>virt-agents</groupid> > > </optionlist> > > </environment> > > <category> > > > -- > > devel mailing list > > devel(a)lists.fedoraproject.org > > https://admin.fedoraproject.org/mailman/listinfo/devel > > -- > trans mailing list > trans(a)lists.fedoraproject.org > https://admin.fedoraproject.org/mailman/listinfo/trans > -- trans mailing list trans(a)lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/trans